Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move in-cluster eventing sub-test to the fixture #12115

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Move in-cluster eventing sub-test to the fixture #12115

merged 1 commit into from
Sep 16, 2021

Conversation

pxsalehi
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Move the binary mode in-cluster test to the fixture to ensure it is called in all fast-integration make targets.

Related issue(s)

@pxsalehi pxsalehi added the area/eventing Issues or PRs related to eventing label Sep 16, 2021
@pxsalehi pxsalehi self-assigned this Sep 16, 2021
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2021
@pxsalehi
Copy link
Contributor Author

/test pre-main-kyma-gardener-gcp-eventing

wozniakjan
wozniakjan approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 16, 2021
@pxsalehi
Copy link
Contributor Author

/test pre-main-kyma-gardener-gcp-eventing

@kyma-bot kyma-bot merged commit db44759 into kyma-project:main Sep 16, 2021
kyma-bot pushed a commit that referenced this pull request Sep 17, 2021
@pxsalehi
Cherry-pick #12085 #12115 (add binary mode to in-cluster eventing tes…
a939216 
…t) (#12113)

* add binary mode to in-cluster eventing test (#12085)

* move in-cluster sub-test to fixture
@k15r k15r mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@adamwalach adamwalach Awaiting requested review from adamwalach

@crabtree crabtree Awaiting requested review from crabtree

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@lindnerby lindnerby Awaiting requested review from lindnerby

@pbochynski pbochynski Awaiting requested review from pbochynski

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@shorim shorim Awaiting requested review from shorim

@skhalash skhalash Awaiting requested review from skhalash

@voigt voigt Awaiting requested review from voigt

Assignees

@wozniakjan wozniakjan

@pxsalehi pxsalehi

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxsalehi @wozniakjan @kyma-bot